Repository navigation
Clear the task identifier cache when a lookup fails - #640
Open
devtechedge wants to merge 1 commit into
Open
devtechedge wants to merge 1 commit into
devtechedge wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getTaskDetailsstores the in-flight task-identifier lookup before it resolves. If that promise rejects, for example on admin shutdown (57P01) or a dropped connection, every later poll with the same task list gets that same rejection. Jobs added afterwards never run, and the runner promise never settles.The lookup is cleared when it rejects, as long as a newer lookup has not already replaced it. The next poll tries again.
The new test rejects the lookup once, then checks the following call looks it up again and the one after that still uses the cache. That test failed before the change and passes after.
Fixes #638.