Add support for include directive in compile and run commands#235
Draft
zarybnicky wants to merge 1 commit intographile:mainfrom
Draft
Add support for include directive in compile and run commands#235zarybnicky wants to merge 1 commit intographile:mainfrom
include directive in compile and run commands#235zarybnicky wants to merge 1 commit intographile:mainfrom
Conversation
benjie
requested changes
Jan 8, 2025
Member
benjie
left a comment
benjie
left a comment
There was a problem hiding this comment.
Thanks for taking this on! Not doing a full review since this is still marked as draft, but there is one thing I noticed.
| const contents = await compileIncludes( | ||
| parsedSettings, | ||
| rawContents, | ||
| filename ? new Set([filename]) : new Set(), |
Member
There was a problem hiding this comment.
Hmmm... This could allow including the same file twice because the path names may not match up. We should make it so that we resolve all paths to absolute paths.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements #217 (I was missing this feature as well)
Performance impact
Security impact
Checklist
yarn lint:fixpasses.yarn testpasses.RELEASE_NOTES.mdfile (if one exists).