Skip to content

Classify cgnat address space as lan #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kadencartwright wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Classify cgnat address space as lan #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions OpenCodeClient/OpenCodeClient/AppState.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@ final class AppState {
if a == 10 || a == 127 { return true }
if a == 192 && b == 168 { return true }
if a == 172 && (16...31).contains(b) { return true }
if a == 100 && (64...127).contains(b) { return true }
if a == 169 && b == 254 { return true }
if host == "0.0.0.0" { return true }
return false
Expand Down
11 changes: 11 additions & 0 deletions OpenCodeClient/OpenCodeClientTests/OpenCodeClientTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,17 @@ struct OpenCodeClientTests {
#expect(AppState.ensureServerURLHasScheme("https://example.com:443") == nil)
}

@Test func serverURLInfoTreatsCGNATAsLocal() {
let cgnat = AppState.serverURLInfo("100.64.1.2:4096")
#expect(cgnat.isLocal == true)
#expect(cgnat.normalized == "http://100.64.1.2:4096")
#expect(cgnat.warning == L10n.t(.errorUsingLanHttp))

let publicAddress = AppState.serverURLInfo("100.128.1.2:4096")
#expect(publicAddress.isLocal == false)
#expect(publicAddress.warning == L10n.t(.errorWanRequiresHttps))
}

@Test @MainActor func migrateLegacyDefaultServerAddress() {
let key = "serverURL"
let previous = UserDefaults.standard.string(forKey: key)
Expand Down