Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion diskcache/persistent.py
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ def maxlen(self, value):
"""Set max length of the deque.

Pops items from left while length greater than max.
Set to None to remove the length limit.

>>> deque = Deque()
>>> deque.extendleft('abcde')
Expand All @@ -146,7 +147,7 @@ def maxlen(self, value):
:param value: max length

"""
self._maxlen = value
self._maxlen = float('inf') if value is None else value
with self._cache.transact(retry=True):
while len(self._cache) > self._maxlen:
self._popleft()
Expand Down
11 changes: 11 additions & 0 deletions tests/test_deque.py
Original file line number Diff line number Diff line change
Expand Up @@ -312,3 +312,14 @@ def test_peek(deque):
assert len(deque) == 1
assert deque.peek() == value
assert len(deque) == 1


def test_maxlen_can_be_reset_to_unlimited(tmp_path):
with dc.Cache(str(tmp_path), eviction_policy='none') as cache:
deque = dc.Deque.fromcache(cache, 'abc', maxlen=3)

deque.maxlen = None

deque.extend('def')
assert list(deque) == list('abcdef')
assert deque.maxlen == float('inf')