Skip to content

Conversation

@spotandjake
Copy link
Member

@spotandjake spotandjake commented Nov 6, 2025

Attempting to bump our emsdk and cmake versions in our Generate.js workflow.

I still need to completely test these changes upstream in binaryen.ml and grain before we should consider merging this. Especially as the tests here only run on the initial commit, not the bot commiting the changed js.

Binaryen.ml tests can be found here: https://github.com/spotandjake/binaryen.ml/tree/spotandjake-es6

@spotandjake spotandjake self-assigned this Nov 6, 2025
@spotandjake spotandjake force-pushed the spotandjake-tooling-update branch from 846056a to e8afa0e Compare November 7, 2025 00:33
@ospencer
Copy link
Member

ospencer commented Nov 7, 2025

@spotandjake is this good to go?

@spotandjake
Copy link
Member Author

I just wanted todo a full test on the grain repo before we merge binaryen.ml looks to be passing though

@spotandjake spotandjake force-pushed the spotandjake-tooling-update branch from e8afa0e to 18a08b8 Compare November 7, 2025 15:28
@spotandjake
Copy link
Member Author

@spotandjake is this good to go?

I think were going to need to discuss furthur if we want to merge this or not, my test in the grain repo grain-lang/grain#2332 showed that it wasn't my es6 changes causing the jsoo out of memory error on ubunut but the emsdk bump. We can fix this rather easily by lowering the number of builders like we already do on windows i'm just not sure if that's optimal or not. The passing branch with es6 changes as well here grain-lang/grain#2331

Happy to rerun my tests with less workers on the emsdk branch once we come to a conclussion to verify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants