feat!: Upgrade to Binaryen v123 #237
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spotandjake
commented
Nov 2, 2025
ospencer
reviewed
Nov 2, 2025
Member
ospencer
left a comment
ospencer
left a comment
There was a problem hiding this comment.
Code looks good to me; holding off on approval until we remove the resolution.
spotandjake
force-pushed
the
spotandjake-123
branch
from
98975ab to
1051aec
Compare
ospencer
force-pushed
the
oscar/122
branch
2 times, most recently
from
54618d1 to
6aa04d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Full Diff: WebAssembly/binaryen@version_122...version_123
Note: Before this can be merged we need to release libbinaryen v123, and switch the esy package over to the released version.