Update grafana-tools/sdk dependency to support datasources as a map #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgeyer
changed the title
This was referenced Mar 22, 2022
Contributor
|
Closing in favor of #248 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Grafana 8.3.0, the dashboard schema permits a datasource to be a map, defining the uid, and type of the datasource.
The upstream grafana-tools/sdk, (which is used in the
analyse dashboardcommand) still expects the previous behavior, and will fail to unmarshal a dashboard which uses this new schema.This PR replaces the dependency with a branch which fixes the problem, but is not yet accepted into the upstream grafana-tools/sdk main branch.
See grafana-tools/sdk#190 for details.
This PR could languish until that PR is merged, however this fix is needed for some downstream projects which depend upon cortextool, so I'm mocking up the interim workaround for anyone else who finds themselves in the same situation.