Skip to content

Add a test that requires all known WGSL language features to be supported #4702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kainino0x merged 2 commits into from
Sep 9, 2026
Merged

Add a test that requires all known WGSL language features to be supported #4702

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd2cedb
Add a test that requires all known WGSL language features to be suppo…
kainino0x Sep 9, 2026
b4e98b4
Merge branch 'main' into require-requires
kainino0x Sep 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions src/webgpu/shader/validation/parse/requires.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ export const description = `Parser validation tests for requires`;

import { makeTestGroup } from '../../../../common/framework/test_group.js';
import { keysOf } from '../../../../common/util/data_tables.js';
import { assert } from '../../../../common/util/util.js';
import { kKnownWGSLLanguageFeatures } from '../../../capability_info.js';
import { ShaderValidationTest } from '../shader_validation_test.js';

Expand Down Expand Up @@ -96,3 +97,17 @@ g.test('wgsl_matches_api')
const code = `requires ${t.params.feature};`;
t.expectCompileResult(t.hasLanguageFeature(t.params.feature), code);
});

g.test('have_all_language_features')
.desc(
`The spec technically requires support for all WGSL language features listed in the spec.
This test enforces that. It should be the ONLY test that fails when a new feature is
unavailable - others should skip themselves.`
)
.params(u => u.combine('feature', kKnownWGSLLanguageFeatures))
.fn(t => {
// First check that the API exposes the feature.
assert(t.hasLanguageFeature(t.params.feature));
// If it does, then also check that WGSL allows it.
t.expectCompileResult(true, `requires ${t.params.feature};`);
});
Loading