fix: datasets: handle error responses #96
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grant Linville <grant@acorn.io>
g-linville
requested review from
StrongMonkey,
drpebcak,
iwilltry42,
njhale,
thedadams and
tylerslaton
Contributor
|
I made a change in gptscript that should mean that this is not needed. In other words, if the run fails, an error should be thrown there. Can you test without this change and latest gptscript? |
Contributor
|
I just realized that the change I referenced above hasn't merged yet. |
Contributor
|
@g-linville The change has been merged to gptscript. You should get proper errors now without having to check for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we were getting errors back from the SDKServer, we were still trying to parse them as JSON. This fixes that.