fixup! feat(security): application token refresh#988
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #988 +/- ##
==========================================
+ Coverage 74.34% 74.36% +0.02%
==========================================
Files 66 66
Lines 3461 3464 +3
==========================================
+ Hits 2573 2576 +3
Misses 688 688
Partials 200 200 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jmattheis
force-pushed
the
sec-update-rekey
branch
from
b2449c9 to
5e81bed
Compare
jmattheis
reviewed
Jul 4, 2026
| app.Token = tokenPublic | ||
| response.RegenerateToken = &model.RegenerateTokenResponse{ | ||
| Token: tokenPrivate, | ||
| if app != nil && app.UserID == auth.GetUserID(ctx) { |
Member
There was a problem hiding this comment.
I'll change this to an early return.
Sorry I shouldn't have missed this important check
No problem, I missed it too in the review :D.
jmattheis
approved these changes
Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorry I shouldn't have missed this important check. This adds back a missing userid check that prevents users from changing the application token for another.
Credits to @kaimandalic for catching this before release and sending in a report in private.