Repository navigation
fix: limit sortKey to at most 255 bytes - #1084
Merged
Merged
Conversation
Much bigger sortKeys could crash gotify.
Member
|
I think it might be helpful to add a go fuzz case for ValidateSortKey and see if there are further problematic inputs? |
KeyBetween("", "A" + 25 zeros + "1") returns smallestInt, which
ValidateOrderKey rejects because it cannot be decremented so nothing
could sort before it.
This appends midpoint("", "") = "V" (0.5) as fraction to the sort key.
Member
Author
|
Good suggestion, added a fuzz test and some fixes for the implementation. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1084 +/- ##
==========================================
+ Coverage 81.61% 81.68% +0.07%
==========================================
Files 69 69
Lines 3241 3260 +19
==========================================
+ Hits 2645 2663 +18
- Misses 596 597 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Much bigger sortKeys could crash gotify.