Allow empty password in proxy auth#977
Open
jellor wants to merge 2 commits intogorilla:mainfrom
Open
Conversation
scalecode-solutions
referenced
this pull request
in scalecode-solutions/magilla
Apr 24, 2026
httpProxyDialer only emitted the Basic credential header when the url.Userinfo had a password component set. That dropped auth for two legitimate cases allowed by RFC 7617: a proxy URL like http://user@proxy/ (no colon, password unset), and an explicit empty password http://user:@proxy/. Some corporate proxies are configured exactly this way. Send auth whenever a username is present, defaulting password to the empty string if url.Userinfo didn't set one. Upstream PR #977. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Empty password should be allowed, when doing proxy authentication using basic auth.
Related Tickets & Documents
Added/updated tests?
have not been included
Run verifications and test
make verifyis passingmake testis passing