fix: rename window variable to avoid Hermes global collision and add listener cleanup#2679
Open
parkjmjohn wants to merge 1 commit into
Open
fix: rename window variable to avoid Hermes global collision and add listener cleanup#2679parkjmjohn wants to merge 1 commit into
parkjmjohn wants to merge 1 commit into
Conversation
…listener cleanup Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This is going to resolve a major crash due to this package. |
mlazari
approved these changes
May 22, 2026
|
@gorhom Please have a look into this |
rareAnshh
approved these changes
May 22, 2026
RomanSytnyk
approved these changes
May 25, 2026
|
It's an important fix |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2678
Problem
In
useAnimatedLayout.ts, theDimensions.addEventListenercallback destructures the event as{ window }. On the Hermes JS engine, worklets run in a UI runtime that exposes a globalwindowobject. When aDimensionschange fires (app switching, entering Maps/Camera, device rotation) while a bottom sheet is mounted, Hermes resolves the capturedwindowvariable through its global lookup instead of the local destructured value — causing a crash.Additionally, the listener was never cleaned up: the
useEffectreturned nothing, so the subscription leaked on every unmount.Fix
windowtowindowDimensionsto avoid the collision with the Hermes global.addEventListenerand callssubscription.remove()in the effect cleanup.