Fix AVPlayer audio tap crash and improve AudioEngine processing format handlingSpherualizer#72
Open
HassanTaleb90 wants to merge 31 commits intogorastudio-git:masterfrom
Open
Fix AVPlayer audio tap crash and improve AudioEngine processing format handlingSpherualizer#72HassanTaleb90 wants to merge 31 commits intogorastudio-git:masterfrom
HassanTaleb90 wants to merge 31 commits intogorastudio-git:masterfrom
Conversation
…conflict resolution`. Solve issue with iOS 18 compilation failure.
…e timeRangeOut variable inside the MTAudioProcessingTapProcessCallback.
…issue when the endSession was done on pause.
…ingTapCreate parameter type error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a crash in AVAudioEngine that occurs when AVPlayer tap is created with an unavailable or missing processing format.
Changes:
This improves reliability when recording SceneKit / AR audio streams.