Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automates the release of Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request contains automated version bumps for the v0.9.1 release. The changes correctly update versions across package.json, Cargo.toml, and lockfiles, and updates CHANGELOG.md accordingly. While the changes in this PR are correct, a review of the related codebase reveals a critical performance and stability issue. Several async functions perform blocking I/O operations (like file access and keyring operations) on the async runtime thread. This can lead to severe performance degradation or deadlocks. For instance, functions in src/token_storage.rs and src/auth.rs call synchronous, blocking functions from src/credential_store.rs. It is strongly recommended to wrap these blocking calls in tokio::task::spawn_blocking in a follow-up PR to prevent blocking the async executor.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
=======================================
Coverage 61.72% 61.72%
=======================================
Files 38 38
Lines 14603 14603
=======================================
Hits 9014 9014
Misses 5589 5589 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@googleworkspace/cli@0.9.1
Patch Changes
.encryption_keyfile when OS keyring is available. Existing file-based keys are migrated into the keyring and the file is removed on next CLI invocation.