fix: apply polygon styling to GeoJSON MultiPolygon features#1727
Open
jamesarich wants to merge 1 commit into
Open
fix: apply polygon styling to GeoJSON MultiPolygon features#1727jamesarich wants to merge 1 commit into
jamesarich wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
GeoJsonMapper matched MultiGeometry in the LineString branch, so a MultiPolygon feature carrying simplestyle properties was given a LineStyle. MapViewRenderer then casts the feature style with 'as? PolygonStyle' when rendering each member polygon, gets null, and draws the polygons with SDK defaults — the feature's fill and stroke colors were silently dropped. Style a multi-geometry whose members are all (recursively) polygons — i.e. a GeoJSON MultiPolygon — with PolygonStyle; mixed collections and MultiLineStrings keep the previous line styling.
jamesarich
force-pushed
the
fix/geojson-multipolygon-style
branch
from
July 16, 2026 18:46
9e1eb4d to
7072a20
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1724 🦕
GeoJsonMapper.toFeaturematchedMultiGeometryin the LineString branch, so a MultiPolygon feature carrying simplestyle properties was given aLineStyle.MapViewRenderercasts the feature style withas? PolygonStylewhen rendering each member polygon, getsnull, and draws the polygons with SDK defaults — the feature'sfill/fill-opacity/strokewere silently dropped. Any per-class MultiPolygon export (coverage contours, choropleths) loses its coloring.Change: a multi-geometry whose members are all (recursively) polygons — i.e. a GeoJSON MultiPolygon — now takes the polygon styling branch. MultiLineStrings and mixed geometry collections keep the previous line styling, so no existing behavior changes for them.
Tests: two new tests in
GeoJsonStylingTest— a styled MultiPolygon yields aPolygonStylewith the expected fill/stroke, and a styled MultiLineString still yields aLineStyle. Full:data:testDebugUnitTestsuite passes.fix:)Developed with AI assistance (Claude Code); the analysis, fix, and tests were reviewed and run locally by the author before submission.