fix: render legacy bridge point markers visible#1726
Open
jamesarich wants to merge 1 commit into
Open
Conversation
The GeoJsonLayer and KmlLayer bridges built the renderer PointStyle with broken color values: GeoJsonLayer hardcoded color = 0, and KmlLayer passed KmlStyle.mMarkerColor — a hue in 0..360 — as if it were ARGB. In both cases the color's alpha channel was 0, and MapViewRenderer derives the marker's alpha from that channel, so every point feature added through the deprecated KML/GeoJSON layer classes rendered fully transparent. GeoJsonLayer now encodes the legacy point style's alpha into the color (hue 0 keeps the default marker look), and KmlLayer converts the marker hue to an opaque ARGB color via Color.HSVToColor, falling back to opaque black when no style is present.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1723 🦕
Every point feature added through the deprecated
GeoJsonLayer/KmlLayerclasses rendered fully transparent in 5.0.0:GeoJsonLayer.toModelFeaturehardcodedPointStyle(color = 0), andKmlLayerpassedKmlStyle.mMarkerColor— a hue in 0..360 — as if it were ARGB. Either way the color's alpha byte was 0, andMapViewRendererderives the marker's alpha from that channel (markerOptions.alpha(Color.alpha(it.color) / 255f)).Change:
GeoJsonLayerencodes the legacy point style's alpha into an otherwise-black color (hue 0 keeps the classic default-marker look).KmlLayerconverts the marker hue to opaque ARGB viaColor.HSVToColor, falling back to opaque black when no style is present.Tests: two new Robolectric regression tests (
GeoJsonLayerMarkerVisibilityTest,KmlLayerMarkerVisibilityTest) asserting the capturedMarkerOptions.alpha == 1ffor a plain point feature/placemark through each bridge. Full:data:testDebugUnitTestsuite passes.Noted in #1723 but intentionally out of scope here:
KmlLayer.toLegacyStylenever mapsIconStylecolor intomMarkerColor, so parsed KML marker colors are currently unused — happy to follow up on that separately if wanted.fix:)Developed with AI assistance (Claude Code); the analysis, fix, and tests were reviewed and run locally by the author before submission.