Skip to content

ci: read the Update Skill Gemini model from GEMINI_MODEL - #1057

Merged
dkhawk merged 3 commits into
mainfrom
fix/update-skill-model
Oct 30, 2026
Merged

dkhawk merged 3 commits into
mainfrom
fix/update-skill-model

Conversation

@kikoso

@kikoso kikoso commented Oct 29, 2026

Copy link
Copy Markdown
Collaborator

The Update Skill workflow has failed on every release since September (latest run: https://github.com/googlemaps/android-maps-compose/actions/runs/37822226850) with:

Gemini API Error (404): models/gemini-2.5-flash is not found for API version v1beta

update_skill.py hardcoded gemini-2.5-flash. It now reads the GEMINI_MODEL repository variable (currently gemini-3.8-flash), which the issue triage workflow already uses successfully, and falls back to the same default as the other scripts.

This is only the model fix. #991 also hardens the workflow against prompt injection; that part can still go in on top, with a one-line conflict in update_skill.py.

Can be verified after merge with a manual workflow_dispatch run of Update Skill.

update_skill.py hardcoded gemini-2.5-flash, which the API no longer serves, so the workflow has failed with a 404 on every release since September. It now reads the GEMINI_MODEL repository variable, as the issue triage workflow already does.
@kikoso kikoso changed the title fix(ci): read the Update Skill Gemini model from GEMINI_MODEL ci: read the Update Skill Gemini model from GEMINI_MODEL Oct 29, 2026
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

Coverage (unit tests)

Compared against a53f06e on main (#1045).

Module Line % Change Branch % Change
maps-compose 15.28% no change 3.76% no change
maps-compose-utils 6.09% no change 4.47% no change
maps-compose-widgets 10.88% no change 11.11% no change
TOTAL 12.99% no change 4.12% no change

Line and branch coverage from unit test reports. History is recorded on the coverage-history branch after each merge to main.

@kikoso
kikoso marked this pull request as ready for review October 29, 2026 17:17
@kikoso
kikoso requested a review from a team as a code owner October 29, 2026 17:17
@googlemaps-bot

googlemaps-bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Coverage (instrumentation tests)

Overall Project 43.69% 🍏

There is no coverage information present for the Files changed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants