[spsaucier]

• Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
• Ensure the tests and linter pass
• Code coverage does not decrease (if any source code was changed)
• Appropriate docs were updated (if necessary)

Fixes #1054

MapLifecycleEventObserver.moveToLifecycleState walks a MapView with Lifecycle.Event.upFrom. DESTROYED is the minimum state, so upFrom(DESTROYED) is null and moveUp() throws IllegalStateException: no event up from DESTROYED.

MapView.onRelease() on main already detaches the observer before moveToDestroyedState(), which covers Compose disposal. The throw remains when the observer is still registered and a lifecycle event arrives after destroy. Released tags through 9.0.1 only remove the observer from onViewDetachedFromWindow. Returning inside moveUp() would not fix this: while (currentLifecycleState != targetState) would never finish. The guard returns at the start of moveToLifecycleState when the state is already DESTROYED. moveToDestroyedState only enters that function while the state is above INITIALIZED, so the path down to onDestroy is unchanged.

This matches a production crash on maps-compose 6.10.0, whose moveUp is the same method as current main (symbolicated to the error(...) line). 29 Android crashes in 30 days on React Native 0.85.3; 22 of them were immediately after the app was backgrounded. Median time since the last interaction was about 3.9s. Sample device: Samsung SM-A166U, Android 16.

./gradlew spotlessKotlinCheck passed. :maps-compose:testDebugUnitTest --tests com.google.maps.android.compose.MapLifecycleEventObserverTest passed (2 tests): a lifecycle event after DESTROYED does not throw or call MapView, and moveToDestroyedState from RESUMED still calls onPause, onStop, and onDestroy.

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[spsaucier]

I've signed the CLA now.

[kikoso]

I've signed the CLA now.

Thanks, @spsaucier ! The CLA check is still failing, but it is not about your signature: the fix commit (b594cc3e) is authored as @saucier-consulting with a different email than the one on your CLA, and the bot checks every commit author. Could you either amend it with the email covered by your CLA (git commit --amend --reset-author, then force-push, which also drops my empty commit), or add that email and account to your CLA and use the rescan link in the check?

The fix itself looks good to me, so LGTM once the CLA is green. Thanks for such a detailed issue, it made this very easy to review!

[kikoso]

nit: setting currentLifecycleState through reflection couples the test to the private field name. We could reach the same states through the public API instead, e.g. onStateChanged(owner, Lifecycle.Event.ON_RESUME) to get to RESUMED and moveToDestroyedState() to get to DESTROYED. Not a blocker though.

[spsaucier]

Dropped the reflection in e29f470. Both tests now reach RESUMED with onStateChanged(owner, ON_RESUME) and DESTROYED with moveToDestroyedState(). Events after that still do not add MapView calls.