Skip to content

fix(ci): resolve Rollup build failures and secure GitHub Actions workflows - #1614

Open
willum070 wants to merge 12 commits into
mainfrom
fix-tests
Open

fix(ci): resolve Rollup build failures and secure GitHub Actions workflows#1614
willum070 wants to merge 12 commits into
mainfrom
fix-tests

Conversation

@willum070

@willum070 willum070 commented Aug 17, 2026

Copy link
Copy Markdown
Collaborator

Here is an updated PR description that includes all the web component refactoring along with the gauntlet of Zizmor security hardening we just completed:


Description

This PR fundamentally resolves a critical CI failure related to Vite/Rollup native binaries. Additionally, it contains a comprehensive security hardening of all GitHub Actions workflows to achieve full compliance with the Zizmor security scanner.

🛠️ CI & Rollup Native Binary Fix

  • Vite Rollup Resolution: Fixed persistent nightly Playwright test failures caused by missing Linux native binaries (@rollup/rollup-linux-x64-gnu). Updated tests.yml to explicitly pass --include=optional to npm ci and force npm rebuild rollup before execution.

🛡️ Zizmor Security Audit Remediation

Hardened all .github/workflows/*.yml files against industry-standard CI/CD attack vectors:

  • Template Injections Mitigated: Eliminated severe bash command-injection risks by securely mapping untrusted GitHub context variables (like github.event.before and step outputs) to intermediate env: variables rather than expanding ${{ }} directly inside run: blocks.
  • Pinned Actions: Locked all third-party GitHub Actions (actions/checkout, google-github-actions/auth, etc.) to specific, immutable commit SHAs to prevent upstream supply-chain attacks.
  • Unsound Conditions Fixed: Replaced if: | with if: |- across multiline conditions to strip trailing newlines, preventing GitHub Actions from inadvertently evaluating them as "truthy" strings.
  • Credential Leakage & Excessive Permissions: Added explicit baseline permissions: contents: read to tests.yml to prevent default privilege escalation. Configured actions/checkout with persist-credentials: false where applicable to prevent GITHUB_TOKEN persistence in local .git/config artifacts.
  • Deprecated Node.js Actions: Upgraded actions/cache and google-github-actions/auth to their latest Node 20 architectures to clear known-vulnerable-actions warnings.

Motivation and Context

These updates ensure the codebase aligns with the latest Google Maps Platform declarative web component patterns, stabilizes the nightly CI pipeline, and proactively secures our automated infrastructure against emerging GitHub Actions vulnerabilities.

Change-Id: I6fe35002e760cf38c46a858c5f8159959e2e4337
@willum070
willum070 requested a review from a team as a code owner August 17, 2026 16:55
Change-Id: Ib0fd0eb403befb40c62a330ce523ced3b8bcbb61
Change-Id: Ic9620fe267b28574e46089c3047a0f781abc1ce5
@willum070 willum070 changed the title fix(ci): resolve missing Rollup native binary during rollup builds fix(ci): resolve Rollup build failures and secure GitHub Actions workflows Aug 17, 2026
Change-Id: Ia9b6caac3e94072d96b549908854bcf012115a41
Change-Id: Ic5643840800c26096a01832906dde1b08844f9cc
Change-Id: I285bf64c83c9845370b10e015ed38a29ebe4ddc4
Change-Id: Ia16464f401d50a7ab5b90b700e6bb3acfc602b77
Change-Id: Id4a97ce9de53cc8dcd5161309535189a701fc066
Change-Id: Icf73e51cdad502a86770e2a42b5edafdab85c853
Change-Id: I3bd2a13d609d13a4a7be074e21b5b5886cc1ab23
Change-Id: Ib283157318432a60a4c18a04972b0e723654dc8b
@willum070
willum070 requested a review from dkhawk August 17, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants