This repository was archived by the owner on Apr 22, 2020. It is now read-only.
Feature/cql#475
Open
peter-janssen wants to merge 2 commits intogooglearchive:masterfrom
Open
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Author
|
@googlebot |
|
CLAs look good, thanks! |
d865650 to
814ca86
Compare
mikesamuel
reviewed
Nov 3, 2017
| @@ -0,0 +1,55 @@ | |||
| /** | |||
| * @license | |||
| * Copyright (C) 2008 Google Inc. | |||
Contributor
There was a problem hiding this comment.
Please put yourself down as the copyright holder. The Apache2 verbiage below then is your grant of license.
814ca86 to
ea13f35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per #451 the required changes to add cql extension. I basically made a copy of the sql extension and replaced the keywords with those from cassandra. The tests are copied over also but with a
usernamestable instead ofusersbecause the latter is a reserved keyword in cql.