This repository was archived by the owner on Apr 22, 2020. It is now read-only.
Rebol and Red grammar#445
Open
draegtun wants to merge 2 commits intogooglearchive:masterfrom
Open
Conversation
Contributor
|
LGTM 👍 As you have variables defined in the outer scope, I would consider wrapping the whole thing inside an IIFE. Maybe also add a small test in |
Author
|
No probs @amroamroamro, the above commit wraps code in Function scope + provides Rebol tests in prettify_test_2.html |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR for issue #367