Skip to content
This repository was archived by the owner on Apr 22, 2020. It is now read-only.

Added SystemVerilog syntax highlighting#433

Open
BooneJS wants to merge 1 commit intogooglearchive:masterfrom
BooneJS:master
Open

Added SystemVerilog syntax highlighting#433
BooneJS wants to merge 1 commit intogooglearchive:masterfrom
BooneJS:master

Conversation

@BooneJS
Copy link
Copy Markdown

@BooneJS BooneJS commented Apr 19, 2016

I've created lang-sv.js based off of lang-vhdl.js, and modified as appropriate. Please consider taking this PR, as I use Perforce Swarm and it uses code-prettify as its syntax highlighter.

It also appears my editor's desire to trim all trailing whitespace caused other differences. I hope that's ok.

Thank you,
BooneJS

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@BooneJS
Copy link
Copy Markdown
Author

BooneJS commented Apr 19, 2016

I signed it!

@googlebot
Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@BooneJS
Copy link
Copy Markdown
Author

BooneJS commented Apr 19, 2016

I added an alternate email address that the commit came from.

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@BooneJS
Copy link
Copy Markdown
Author

BooneJS commented Apr 19, 2016

BTW, this fixes Feature Request Issue #310.

@TCWORLD
Copy link
Copy Markdown

TCWORLD commented Feb 11, 2018

Any update on the status of this pull request?

The stack exchange network uses Prettify for it's syntax highlighting. There are a few of us wanting Verilog/SystemVerilog (SV) syntax highlighting support (Q on the StackExchange Meta), but that is entirely dependent on Prettify getting SV support.

@ahmetkakacak
Copy link
Copy Markdown

@BooneJS I'm asking this question, because I don't know the procedure here. Will this commit be merged? Since Stack Overflow uses code-prettify, your extension would be great for many people.

@BooneJS
Copy link
Copy Markdown
Author

BooneJS commented Feb 12, 2018

As far as I know, I’ve signed the Google CLA and it’s all ready for them to accept the pull request.

@73rhodes
Copy link
Copy Markdown

73rhodes commented Dec 6, 2019

This PR was issued over 3 years ago. Can it be merged?

@BooneJS
Copy link
Copy Markdown
Author

BooneJS commented Dec 7, 2019

There's 44 PRs and very little activity across this library. This may never be merged.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants