Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request officially marks the repository as deprecated by updating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the README.md file to include a deprecation notice for the sdk-platform-java repository. The review feedback points out that the provided link in the deprecation notice, which directs to a specific client library within google-cloud-java, might be misleading given that sdk-platform-java is a monorepo. It suggests updating the link to the root of google-cloud-java or providing more specific instructions for users to find the moved components.
README.md
Outdated
| @@ -1,3 +1,5 @@ | |||
| **_THIS REPOSITORY IS DEPRECATED. ALL OF ITS CONTENT AND HISTORY HAS BEEN MOVED TO [GOOGLE-CLOUD-JAVA](https://github.com/googleapis/google-cloud-java/tree/main/java-bigquerystorage)_** | |||
There was a problem hiding this comment.
The deprecation notice states that "ALL OF ITS CONTENT AND HISTORY HAS BEEN MOVED TO GOOGLE-CLOUD-JAVA". However, the provided link points to a specific client library (java-bigquerystorage) within the google-cloud-java repository.
Given that sdk-platform-java is described as a monorepo containing foundational components like gapic-generator-java and gax-java, it's unlikely that all its content and history have been moved to a single client library's directory. This could be misleading for users looking for the new location of the entire sdk-platform-java project or its various components.
Please verify the correct redirection link. If the entire repository's content has been distributed across google-cloud-java, it might be better to link to the root of google-cloud-java or provide more specific instructions for finding the moved components.
| **_THIS REPOSITORY IS DEPRECATED. ALL OF ITS CONTENT AND HISTORY HAS BEEN MOVED TO [GOOGLE-CLOUD-JAVA](https://github.com/googleapis/google-cloud-java/tree/main/java-bigquerystorage)_** | |
| **_THIS REPOSITORY IS DEPRECATED. ALL OF ITS CONTENT AND HISTORY HAS BEEN MOVED TO [GOOGLE-CLOUD-JAVA](https://github.com/googleapis/google-cloud-java)_** |
|
|
2 participants
No description provided.