Skip to content

Conversation

@dazuma
Copy link
Contributor

@dazuma dazuma commented Jan 7, 2025

This change adds support for Ruby 3.4 to GAS, for protobuf releases.

  • Pin rake-compiler and rake-compiler-dock to the latest versions (1.2.9 and 1.8.0, respectively), which have Ruby 3.4 support.
  • Re-pin rake-compiler-dock images to the SHAs corresponding to version 1.8.0.
  • Re-pin the gems and rake gems to the latest and greatest (1.3.0 and 13.2.1, respectively).
  • rake-compiler-dock 1.8.0 images use the latest patchlevel of each Ruby version, different from previous images which used the earliest (i.e. *.0) patchlevel. This required us to update the logic that determines RUBY_CC_VERSION.
  • Updated the default Ruby version lists to drop 2.7 and add 3.4.
  • Added Ruby 3.4 to the CI matrix so the tests can test the 3.4 protobuf build for runtime functionality.

Also:

  • Added a test to ensure cross-builds against all Ruby versions are successful.
  • Updated the gas build tool to install dependencies automatically if not present. Solves a corner case where tests hang on user prompt if the bundle hasn't been installed.
  • Added a cleanup between builds of different platforms. Solves a rare corner case where one platform build interferes with another.

@dazuma dazuma requested a review from a team as a code owner January 7, 2025 19:38
@dazuma dazuma force-pushed the pr/gas-34 branch 3 times, most recently from 4f3ab47 to 88a151d Compare January 8, 2025 04:02
@dazuma dazuma marked this pull request as draft January 8, 2025 04:02
@dazuma dazuma changed the title feat: Support Ruby 3.4 feat(gas): Support Ruby 3.4 Jan 8, 2025
@dazuma dazuma marked this pull request as ready for review January 8, 2025 19:15
@dazuma dazuma requested a review from aandreassa January 8, 2025 19:22
@dazuma
Copy link
Contributor Author

dazuma commented Jan 8, 2025

/cc @zhangskz

@dazuma dazuma merged commit f19940d into googleapis:main Jan 8, 2025
5 checks passed
@dazuma dazuma deleted the pr/gas-34 branch January 9, 2025 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants