-
Notifications
You must be signed in to change notification settings - Fork 7
deps: adds limits to numpy installs under 3.10 for dataproc #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👎 on this change. I suspect dataproc's problem isn't really because of db-dtypes incompatibility but because of older pandas + newer numpy not playing nicely.
I wouldn't want to prevent all 3.10 users from using the latest numpy.
Edit: Discussed offline. Numpy already doesn't support >= 2.3.0 on Python 3.10. While this change feels redundant in that case, it shouldn't do any harm.
|
As noted in my internal chat comment. I am talking to the Dataproc team to see if there are alternatives that meet their needs but don't affect other users of this library. More to come. |
🤖 I have created a release *beep* *boop* --- ## [1.4.4](v1.4.3...v1.4.4) (2025-09-08) ### Dependencies * Adds limits to numpy installs under 3.10 for dataproc ([#370](#370)) ([6d79280](6d79280)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [1.4.4](googleapis/python-db-dtypes-pandas@v1.4.3...v1.4.4) (2025-09-08) ### Dependencies * Adds limits to numpy installs under 3.10 for dataproc ([#370](googleapis/python-db-dtypes-pandas#370)) ([6d79280](googleapis/python-db-dtypes-pandas@6d79280)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
The Google Dataproc team requested this change.
CONTEXT:
When installing
python-bigquery[pandas](which depends onpython-db-dtypes-pandas, which depends onnumpy) an issue arises becausedb-dtypesattempts to install a version ofnumpygreater than2.2.6. Due to requirements to reproduce the Dataproc environment, they cannot allow installs ofnumpygreater than2.2.6so they requested that we add an upper limit.