-
Notifications
You must be signed in to change notification settings - Fork 68
feat: Initial support for biglake iceberg tables #2409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
9a1c516 to
f87a256
Compare
f87a256 to
b0337c6
Compare
tswast
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it!
bigframes/session/iceberg.py
Outdated
| "Authorization": f"Bearer {credentials.token}", | ||
| "Content-Type": "application/json", | ||
| "header.x-goog-user-project": user_project_id, | ||
| # "token": token, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Leftover test code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
tests/system/small/test_iceberg.py
Outdated
| bpd.reset_session() | ||
| df = bpd.read_gbq( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we introducing some potential flakiness / race conditions? I could anticipate this breaking other tests that create a global session, since this won't be the typical us multiregion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah on closer consideration, should close the session after and undo location-setting side-effect.
Added test fixture to do this in new revision
5054d66 to
2a7b4ed
Compare
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕