Skip to content

Conversation

@TrevorBergeron
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. labels Jan 27, 2026
@TrevorBergeron TrevorBergeron force-pushed the iceberg_tables branch 3 times, most recently from 9a1c516 to f87a256 Compare January 29, 2026 02:18
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Feb 7, 2026
@TrevorBergeron TrevorBergeron marked this pull request as ready for review February 9, 2026 20:38
@TrevorBergeron TrevorBergeron requested review from a team as code owners February 9, 2026 20:38
@TrevorBergeron TrevorBergeron requested a review from tswast February 9, 2026 20:38
Copy link
Collaborator

@tswast tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

"Authorization": f"Bearer {credentials.token}",
"Content-Type": "application/json",
"header.x-goog-user-project": user_project_id,
# "token": token,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leftover test code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

Comment on lines 37 to 38
bpd.reset_session()
df = bpd.read_gbq(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we introducing some potential flakiness / race conditions? I could anticipate this breaking other tests that create a global session, since this won't be the typical us multiregion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah on closer consideration, should close the session after and undo location-setting side-effect.
Added test fixture to do this in new revision

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigquery Issues related to the googleapis/python-bigquery-dataframes API. size: xl Pull request size is extra large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants