Skip to content

Conversation

@olavloite
Copy link
Collaborator

The SHOW DEFAULT_TRANSACTION_ISOLATION command can be used in PostgreSQL to query the current default isolation level for a connection. This command was not supported by the Spanner JDBC driver and PGAdapter, which made it difficult for customers to check whether their attempt to set a different default isolation level actually worked.

Updates GoogleCloudPlatform/pgadapter#3984

@olavloite olavloite requested review from a team as code owners January 5, 2026 11:43
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: spanner Issues related to the googleapis/java-spanner API. labels Jan 5, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello @olavloite, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the Spanner JDBC driver and PGAdapter by introducing support for the PostgreSQL SHOW DEFAULT_TRANSACTION_ISOLATION command. This feature allows users to easily inspect the configured default transaction isolation level, which was previously difficult to verify. Additionally, the behavior of SHOW TRANSACTION_ISOLATION_LEVEL has been refined to accurately reflect the isolation level of an active transaction, providing more precise information to users. These changes improve the diagnostic capabilities and overall compatibility with PostgreSQL-specific commands.

Highlights

  • PostgreSQL SHOW DEFAULT_TRANSACTION_ISOLATION Support: The Spanner JDBC driver and PGAdapter now support the SHOW DEFAULT_TRANSACTION_ISOLATION command, allowing users to query the default isolation level for a connection.
  • Improved SHOW TRANSACTION_ISOLATION_LEVEL Behavior: The SHOW TRANSACTION_ISOLATION_LEVEL command now correctly returns the current transaction's isolation level if a transaction is active, otherwise it returns the default isolation level.
  • Client-Side Statement Definition: A new client-side statement definition has been added to PG_ClientSideStatements.json to recognize and handle SHOW DEFAULT_TRANSACTION_ISOLATION queries.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the SHOW DEFAULT_TRANSACTION_ISOLATION command for PostgreSQL databases, which is a valuable feature for users to verify their connection's default isolation level. The implementation is clean and follows the existing pattern for client-side statements. Additionally, this PR includes a fix for SHOW TRANSACTION_ISOLATION_LEVEL to correctly report the current transaction's isolation level instead of a hardcoded value. The changes are well-structured and correct. I have one minor suggestion to improve code conciseness.

The `SHOW DEFAULT_TRANSACTION_ISOLATION` command can be used in PostgreSQL to query
the current default isolation level for a connection. This command was not supported
by the Spanner JDBC driver and PGAdapter, which made it difficult for customers to
check whether their attempt to set a different default isolation level actually worked.

Updates GoogleCloudPlatform/pgadapter#3984
@olavloite olavloite force-pushed the default-transaction-isolation branch from 309b060 to eea43dd Compare January 5, 2026 12:50
@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 5, 2026
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 5, 2026
@olavloite olavloite merged commit aec0515 into main Jan 5, 2026
42 of 43 checks passed
@olavloite olavloite deleted the default-transaction-isolation branch January 5, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants