Skip to content

fix: adjust the initial polling delay for ddl operations #4275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hengfengli wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: adjust the initial polling delay for ddl operations #4275

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1102920
fix: adjust the initial polling delay for ddl operations
hengfengli Dec 18, 2025
1b78b48
fix the lint issue
hengfengli Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 25 additions & 5 deletions google-cloud-spanner/src/main/java/com/google/cloud/spanner/SpannerOptions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1148,26 +1148,46 @@ private static String createCustomClientLibToken(String token) {

protected Builder() {
// Manually set retry and polling settings that work.
OperationTimedPollAlgorithm longRunningPollingAlgorithm =

// The polling setting with a short initial delay as we expect
// it to return soon.
OperationTimedPollAlgorithm shortInitialPollingDelayAlgorithm =
OperationTimedPollAlgorithm.create(
RetrySettings.newBuilder()
.setInitialRpcTimeoutDuration(Duration.ofSeconds(60L))
.setMaxRpcTimeoutDuration(Duration.ofSeconds(600L))
.setInitialRetryDelayDuration(Duration.ofSeconds(20L))
.setInitialRetryDelayDuration(Duration.ofSeconds(1L))
.setMaxRetryDelayDuration(Duration.ofSeconds(45L))
.setRetryDelayMultiplier(1.5)
.setRpcTimeoutMultiplier(1.5)
.setTotalTimeoutDuration(Duration.ofHours(48L))
.build());
databaseAdminStubSettingsBuilder
.createDatabaseOperationSettings()
.setPollingAlgorithm(longRunningPollingAlgorithm);
.setPollingAlgorithm(shortInitialPollingDelayAlgorithm);
databaseAdminStubSettingsBuilder
.updateDatabaseDdlOperationSettings()
.setPollingAlgorithm(shortInitialPollingDelayAlgorithm);

// The polling setting with a long initial delay as we expect
// the operation to take a bit long time to return.
OperationTimedPollAlgorithm longInitialPollingDelayAlgorithm =
OperationTimedPollAlgorithm.create(
RetrySettings.newBuilder()
.setInitialRpcTimeoutDuration(Duration.ofSeconds(60L))
.setMaxRpcTimeoutDuration(Duration.ofSeconds(600L))
.setInitialRetryDelayDuration(Duration.ofSeconds(20L))
.setMaxRetryDelayDuration(Duration.ofSeconds(45L))
.setRetryDelayMultiplier(1.5)
.setRpcTimeoutMultiplier(1.5)
.setTotalTimeoutDuration(Duration.ofHours(48L))
.build());
databaseAdminStubSettingsBuilder
.createBackupOperationSettings()
.setPollingAlgorithm(longRunningPollingAlgorithm);
.setPollingAlgorithm(longInitialPollingDelayAlgorithm);
databaseAdminStubSettingsBuilder
.restoreDatabaseOperationSettings()
.setPollingAlgorithm(longRunningPollingAlgorithm);
.setPollingAlgorithm(longInitialPollingDelayAlgorithm);
}

Builder(SpannerOptions options) {
Expand Down