Skip to content

chore(spanner): remove allow(dead_code) annotations - #6506

Open
olavloite wants to merge 1 commit into
googleapis:mainfrom
olavloite:spanner-cleanup-allow-dead-code
Open

chore(spanner): remove allow(dead_code) annotations#6506
olavloite wants to merge 1 commit into
googleapis:mainfrom
olavloite:spanner-cleanup-allow-dead-code

Conversation

@olavloite

Copy link
Copy Markdown
Contributor

Remove several obsolete allow(dead_code) annotations from the Spanner client.

Remove several obsolete allow(dead_code) annotations from the Spanner client.
@olavloite
olavloite requested review from a team as code owners August 22, 2026 10:19
@product-auto-label product-auto-label Bot added the api: spanner Issues related to the Spanner API. label Aug 22, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleans up unused #[allow(dead_code)] attributes and outdated TODO comments across several files in the spanner crate, including client.rs, key.rs, mutation.rs, builder.rs, stream.rs, and types.rs. Additionally, it adds a targeted #[allow(dead_code)] attribute and a TODO comment to the headers field and method in BatchWriteStream to prepare for future metrics and header recording. There are no review comments, and I have no feedback to provide.

@codecov

codecov Bot commented Aug 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.39%. Comparing base (4084332) to head (ce60f84).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6506      +/-   ##
==========================================
- Coverage   96.39%   96.39%   -0.01%     
==========================================
  Files         301      301              
  Lines       84762    84762              
==========================================
- Hits        81710    81703       -7     
- Misses       3052     3059       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant