Skip to content

impl(gax-internal): support server-side streaming - #6504

Open
suzmue wants to merge 2 commits into
googleapis:mainfrom
suzmue:server-streaming
Open

impl(gax-internal): support server-side streaming#6504
suzmue wants to merge 2 commits into
googleapis:mainfrom
suzmue:server-streaming

Conversation

@suzmue

@suzmue suzmue commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Add the execute_server_streaming helper on the gRPC transport client to support server-side streaming RPCs. The helper handles converting domain requests to proto messages and decodes the response stream using decode_response_stream into a ResponseReceiver.

Gate server streaming execution helpers under the
google_cloud_unstable_gapic_streaming cfg.

Enable include_server_streaming_methods for Showcase in librarian.yaml, regenerate google-cloud-showcase-v1beta1, and add integration tests for server-side streaming.

For #2318

Add the execute_server_streaming helper on the gRPC transport client to
support server-side streaming RPCs. The helper handles converting domain
requests to proto messages and decodes the response stream using
decode_response_stream into a ResponseReceiver.

Gate server streaming execution helpers under the
google_cloud_unstable_gapic_streaming cfg.

Enable include_server_streaming_methods for Showcase in librarian.yaml,
regenerate google-cloud-showcase-v1beta1, and add integration tests for
server-side streaming.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for server-side streaming RPCs in the Rust SDK. It implements execute_server_streaming in the internal gRPC client, adds unimplemented server streaming stubs, and updates the generated showcase client, builders, and transport layers to support streaming methods like expand, stream_blurbs, and attempt_streaming_sequence. Comprehensive integration and unit tests are also included. The review feedback recommends using the fully qualified path google_cloud_gax::streaming::decode_response_stream in src/gax-internal/src/grpc.rs to ensure consistency with the fully qualified ResponseReceiver type used nearby.

Comment thread src/gax-internal/src/grpc.rs
@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.39%. Comparing base (e532748) to head (21d79f2).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6504      +/-   ##
==========================================
- Coverage   96.39%   96.39%   -0.01%     
==========================================
  Files         301      301              
  Lines       84762    84800      +38     
==========================================
+ Hits        81710    81744      +34     
- Misses       3052     3056       +4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@suzmue
suzmue marked this pull request as ready for review August 22, 2026 00:32
@suzmue
suzmue requested review from a team as code owners August 22, 2026 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant