perf(bigquery): borrow schemas during REST row conversion - #6503
Open
fornwall wants to merge 3 commits into
Open
perf(bigquery): borrow schemas during REST row conversion#6503fornwall wants to merge 3 commits into
fornwall wants to merge 3 commits into
Conversation
Row conversion cloned table field schemas and allocated temporary schema wrappers for every cell, even though conversion only reads schema metadata. Pass borrowed field slices through the recursive conversion instead, which removes a deep `TableFieldSchema` clone, an `Arc`, and a `TableSchema` allocation per cell for scalar, nested and repeated values. Also reserve the cell vector up front, now that the column count is known before the loop runs. Signed-off-by: Fredrik Fornwall <fredrik@fornwall.net>
product-auto-label
Bot
added
the
api: bigquery
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the BigQuery row conversion logic to optimize allocations and simplify the code by passing TableFieldSchema directly to conversion functions instead of reconstructing intermediate Schema objects. The review feedback suggests a further optimization in convert_repeated to pre-allocate the values list using ListValue::with_capacity since the input size is known beforehand.
Signed-off-by: Fredrik Fornwall <fredrik@fornwall.net>
`convert_row` and `convert_repeated` own the cell vector they receive, so they can map it in place with `Value::take()` instead of building a second vector alongside it. This drops one `Vec` allocation per row, per repeated field and per nested record, and subsumes the capacity reservation added earlier. Signed-off-by: Fredrik Fornwall <fredrik@fornwall.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Row conversion cloned table field schemas and allocated temporary schema wrappers for every cell, even though conversion only reads schema metadata.
Pass borrowed field slices through the recursive conversion instead, which removes a deep
TableFieldSchemaclone, anArc, and aTableSchemaallocation per cell for scalar, nested and repeated values.Also reserve the cell vector up front, now that the column count is known before the loop runs.