Skip to content

ci(pubsub): re-enable exactly-once test#5262

Merged
dbolduc merged 1 commit intogoogleapis:mainfrom
dbolduc:re-enable-eod-test
Apr 4, 2026
Merged

ci(pubsub): re-enable exactly-once test#5262
dbolduc merged 1 commit intogoogleapis:mainfrom
dbolduc:re-enable-eod-test

Conversation

@dbolduc
Copy link
Copy Markdown
Member

@dbolduc dbolduc commented Apr 4, 2026

Related to #5063

It looks like #3975 was the root problem for these acks failing. That is fixed, so re-enable the test, and see if we catch any other sort of error.

From longrunning benchmarks, I have only seen transient errors, which should be fixed by implementing the exactly once retry loop (#4804).

@product-auto-label product-auto-label bot added the api: pubsub Issues related to the Pub/Sub API. label Apr 4, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.98%. Comparing base (e92b011) to head (5bc82ac).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5262   +/-   ##
=======================================
  Coverage   97.98%   97.98%           
=======================================
  Files         215      215           
  Lines       44904    44904           
=======================================
+ Hits        43998    44000    +2     
+ Misses        906      904    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbolduc dbolduc marked this pull request as ready for review April 4, 2026 05:15
@dbolduc dbolduc requested a review from a team as a code owner April 4, 2026 05:15
@dbolduc dbolduc merged commit c166879 into googleapis:main Apr 4, 2026
36 checks passed
@dbolduc dbolduc deleted the re-enable-eod-test branch April 4, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants