feat(pubsub): add nack() method to Handler for AtLeastOnce#5261
Open
suzmue wants to merge 1 commit intogoogleapis:mainfrom
Open
feat(pubsub): add nack() method to Handler for AtLeastOnce#5261suzmue wants to merge 1 commit intogoogleapis:mainfrom
suzmue wants to merge 1 commit intogoogleapis:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5261 +/- ##
==========================================
- Coverage 97.98% 97.98% -0.01%
==========================================
Files 215 215
Lines 44904 44957 +53
==========================================
+ Hits 44000 44051 +51
- Misses 904 906 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dbolduc
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, nacking a message in the Pub/Sub subscriber required dropping the handler (drop(h)). While effective, this is less discoverable and readable than an explicit nack(). This change introduces explicit nack() methods to the message handlers for Handler and AtLeastOnce. There is also a private nack() added to ExactlyOnce. Additionally, this change updates the module and method documentation to use the new nack() methods instead of drop().