-
Notifications
You must be signed in to change notification settings - Fork 111
chore: update librarian version #4656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4656 +/- ##
==========================================
- Coverage 95.01% 95.00% -0.02%
==========================================
Files 196 196
Lines 7525 7525
==========================================
- Hits 7150 7149 -1
- Misses 375 376 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| commit: b976ae6b65bb9601e7bb01ed07f30b7cff442675 | ||
| sha256: 471178ce7594f5f179ec2c86eab7f331dd92218dbdb3ed4768e7d83e0dd4dfbc | ||
| commit: d5aae90e66afa2cb7d5e981480519388be67ef17 | ||
| sha256: 72dbd052b609780af1dd4e85de194eeeb8e92e7ccc22376cd1b3b89b7238788f | ||
| googleapis: | ||
| commit: aa950c94fca3ea74ab574d0538b9ff1d57187f91 | ||
| sha256: 6daa9905843049b81339b2687f5366a96fe62a4528df032db24a3e5c2f71e502 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are the SHAs updated too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The behavior of 'librarian update' is to update them to the latest version (https://github.com/googleapis/librarian/blob/main/internal/librarian/update.go#L118C13-L118C25), command used in librarianops generate command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe stop using librarianops until that is fixed and start using the playbook?
I will reject all requests that change the SHAs and librarian version. And rollback any PRs that accidentally get through.
Update librarian version to @main (v0.8.2-0.20260211000539-60845d81354b).
We require the updates from pull request #4655 in the google-cloud-rust repository. To ensure the changes are easier to evaluate, we are first isolating the librarian version updates into a separate pull request.