Skip to content

Conversation

@miguelvelezsa
Copy link

@miguelvelezsa miguelvelezsa commented Feb 11, 2026

Update librarian version to @main (v0.8.2-0.20260211000539-60845d81354b).

We require the updates from pull request #4655 in the google-cloud-rust repository. To ensure the changes are easier to evaluate, we are first isolating the librarian version updates into a separate pull request.

@miguelvelezsa miguelvelezsa requested a review from a team as a code owner February 11, 2026 01:05
@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.00%. Comparing base (69fc2c1) to head (8600485).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4656      +/-   ##
==========================================
- Coverage   95.01%   95.00%   -0.02%     
==========================================
  Files         196      196              
  Lines        7525     7525              
==========================================
- Hits         7150     7149       -1     
- Misses        375      376       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment on lines -22 to -26
commit: b976ae6b65bb9601e7bb01ed07f30b7cff442675
sha256: 471178ce7594f5f179ec2c86eab7f331dd92218dbdb3ed4768e7d83e0dd4dfbc
commit: d5aae90e66afa2cb7d5e981480519388be67ef17
sha256: 72dbd052b609780af1dd4e85de194eeeb8e92e7ccc22376cd1b3b89b7238788f
googleapis:
commit: aa950c94fca3ea74ab574d0538b9ff1d57187f91
sha256: 6daa9905843049b81339b2687f5366a96fe62a4528df032db24a3e5c2f71e502
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are the SHAs updated too?

Copy link
Author

@miguelvelezsa miguelvelezsa Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The behavior of 'librarian update' is to update them to the latest version (https://github.com/googleapis/librarian/blob/main/internal/librarian/update.go#L118C13-L118C25), command used in librarianops generate command.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe stop using librarianops until that is fixed and start using the playbook?

I will reject all requests that change the SHAs and librarian version. And rollback any PRs that accidentally get through.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants