test(pubsub): refactor sample integration tests for robustness#4654
Merged
haphungw merged 3 commits intogoogleapis:mainfrom Feb 11, 2026
Merged
test(pubsub): refactor sample integration tests for robustness#4654haphungw merged 3 commits intogoogleapis:mainfrom
haphungw merged 3 commits intogoogleapis:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4654 +/- ##
=======================================
Coverage 95.00% 95.00%
=======================================
Files 196 196
Lines 7525 7525
=======================================
Hits 7149 7149
Misses 376 376 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dbolduc
reviewed
Feb 11, 2026
Member
dbolduc
left a comment
There was a problem hiding this comment.
Thanks. Could be a bit simpler
dbolduc
reviewed
Feb 11, 2026
dbolduc
approved these changes
Feb 11, 2026
5c866a1 to
5e23661
Compare
dbolduc
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the tests into 2 primary workflows:
topics()andsubscriptions().The
subscriptionworkflow now creates a single test topic once and reuses it across multiple samples, reducing the time spent waiting for resource provisioning.Fixes #4652