Skip to content

test(pubsub): add subscriber sample using into_stream()#4592

Merged
haphungw merged 7 commits intogoogleapis:mainfrom
haphungw:session-sample-update
Feb 10, 2026
Merged

test(pubsub): add subscriber sample using into_stream()#4592
haphungw merged 7 commits intogoogleapis:mainfrom
haphungw:session-sample-update

Conversation

@haphungw
Copy link
Contributor

@haphungw haphungw commented Feb 6, 2026

For #4574

@product-auto-label product-auto-label bot added api: pubsub Issues related to the Pub/Sub API. samples Issues that are directly related to samples. labels Feb 6, 2026
@haphungw haphungw force-pushed the session-sample-update branch from bd2ed97 to 179e079 Compare February 6, 2026 19:40
@haphungw haphungw force-pushed the session-sample-update branch 2 times, most recently from 95548e1 to fd1348a Compare February 6, 2026 19:59
@haphungw haphungw changed the title test(pubsub): update quickstart_subscriber sample to use into_stream() test(pubsub): add subscriber sample using into_stream() Feb 6, 2026
@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.02%. Comparing base (4662c64) to head (8d6298e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4592      +/-   ##
==========================================
+ Coverage   95.01%   95.02%   +0.01%     
==========================================
  Files         195      195              
  Lines        7458     7464       +6     
==========================================
+ Hits         7086     7093       +7     
+ Misses        372      371       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@haphungw haphungw marked this pull request as ready for review February 6, 2026 20:15
@haphungw haphungw requested a review from a team February 6, 2026 20:15
@haphungw haphungw force-pushed the session-sample-update branch from fd1348a to 8d6298e Compare February 6, 2026 22:07
Copy link
Collaborator

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is blocking some other work, merge and we can iterate. Otherwise it may need to work until Monday, I am about to stop working.

@dbolduc dbolduc added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 6, 2026
@dbolduc
Copy link
Member

dbolduc commented Feb 6, 2026

merge

We should get #4590 in first, then rebase this PR on top of that one.

@dbolduc dbolduc removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 9, 2026
@haphungw haphungw force-pushed the session-sample-update branch from b544796 to 6114676 Compare February 9, 2026 19:26
@haphungw haphungw marked this pull request as draft February 9, 2026 19:38
@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.01%. Comparing base (90bb237) to head (53c2306).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4592   +/-   ##
=======================================
  Coverage   95.01%   95.01%           
=======================================
  Files         196      196           
  Lines        7525     7525           
=======================================
  Hits         7150     7150           
  Misses        375      375           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@haphungw haphungw force-pushed the session-sample-update branch 4 times, most recently from e2f5c86 to 8794841 Compare February 9, 2026 22:59
@haphungw haphungw marked this pull request as ready for review February 9, 2026 23:26
@haphungw haphungw requested a review from a team as a code owner February 9, 2026 23:26
Copy link
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: when a PR is doing two things, you block both things on each other. I am happy to review such PRs, but you will find that life is easier doing one thing at a time.

I would probably:

  1. add the subscriber_stream() test in this PR + the sample.
  2. refactor to consolidate the test runners in a follow up PR (because that half of things is less obvious)

Up to you though.

// See the License for the specific language governing permissions and
// limitations under the License.

// [START rust_pubsub_subscriber_stream]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove the region tag until we are ready to use the sample somewhere?

Copy link
Member

@dbolduc dbolduc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the two comments are not helping us, but other than that LGTM

@haphungw haphungw force-pushed the session-sample-update branch 2 times, most recently from 99bae08 to b252330 Compare February 10, 2026 21:07
@dbolduc
Copy link
Member

dbolduc commented Feb 10, 2026

Aaarrrggh I think my changes from #4648 messed up the diff for this PR. My bad. Can you rebase and fix the conflicts 😬 ?

@haphungw haphungw force-pushed the session-sample-update branch from b252330 to 53c2306 Compare February 10, 2026 22:25
@haphungw haphungw merged commit baf4159 into googleapis:main Feb 10, 2026
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments