test(pubsub): add subscriber sample using into_stream()#4592
test(pubsub): add subscriber sample using into_stream()#4592haphungw merged 7 commits intogoogleapis:mainfrom
subscriber sample using into_stream()#4592Conversation
bd2ed97 to
179e079
Compare
95548e1 to
fd1348a
Compare
quickstart_subscriber sample to use into_stream()subscriber sample using into_stream()
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4592 +/- ##
==========================================
+ Coverage 95.01% 95.02% +0.01%
==========================================
Files 195 195
Lines 7458 7464 +6
==========================================
+ Hits 7086 7093 +7
+ Misses 372 371 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fd1348a to
8d6298e
Compare
coryan
left a comment
There was a problem hiding this comment.
If this is blocking some other work, merge and we can iterate. Otherwise it may need to work until Monday, I am about to stop working.
We should get #4590 in first, then rebase this PR on top of that one. |
b544796 to
6114676
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4592 +/- ##
=======================================
Coverage 95.01% 95.01%
=======================================
Files 196 196
Lines 7525 7525
=======================================
Hits 7150 7150
Misses 375 375 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
e2f5c86 to
8794841
Compare
dbolduc
left a comment
There was a problem hiding this comment.
FYI: when a PR is doing two things, you block both things on each other. I am happy to review such PRs, but you will find that life is easier doing one thing at a time.
I would probably:
- add the
subscriber_stream()test in this PR + the sample. - refactor to consolidate the test runners in a follow up PR (because that half of things is less obvious)
Up to you though.
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| // [START rust_pubsub_subscriber_stream] |
There was a problem hiding this comment.
Maybe remove the region tag until we are ready to use the sample somewhere?
dbolduc
left a comment
There was a problem hiding this comment.
I think the two comments are not helping us, but other than that LGTM
99bae08 to
b252330
Compare
|
Aaarrrggh I think my changes from #4648 messed up the diff for this PR. My bad. Can you rebase and fix the conflicts 😬 ? |
b252330 to
53c2306
Compare
For #4574