samples(storage): add object soft delete policy snippets#34674
samples(storage): add object soft delete policy snippets#34674shubhangi-google wants to merge 1 commit into
Conversation
shubhangi-google
changed the title
|
Here is the summary of changes. You are about to add 6 region tags.
This comment is generated by snippet-bot.
|
torreypayne
left a comment
torreypayne
left a comment
There was a problem hiding this comment.
@shubhangi-google can you update the commit message and PR to lowercase samples, and also add a verb? Something like samples(storage): add object soft delete policy snippets
| storage = Google::Cloud::Storage.new | ||
| bucket = storage.bucket bucket_name | ||
|
|
||
| file = bucket.restore_file file_name, generation |
There was a problem hiding this comment.
I see we call .to_i on retention_duration_seconds in 'google-cloud-storage/samples/storage_set_soft_delete_policy.rb', since CLI arguments are strings. Should we do similarly for generation?
torreypayne
left a comment
torreypayne
left a comment
There was a problem hiding this comment.
I also saw your commit messages weren't formatted as conventional commits; can you update those so release-please can properly format the changelog?
shubhangi-google
changed the title
shubhangi-google
force-pushed
the
samples_soft_delete_policy
branch
from
0eef952 to
402431d
Compare
done |
done |
2 participants
This PR introduces following sample: