Skip to content

feat(api_core): restrict DirectPath to default universe - #19163

Draft
daniel-sanche wants to merge 1 commit into
mainfrom
gate_directpath_create_channel
Draft

daniel-sanche wants to merge 1 commit into
mainfrom
gate_directpath_create_channel

Conversation

@daniel-sanche

Copy link
Copy Markdown
Contributor

DirectPath is only supported in the Google Default Universe (googleapis.com).

Previously, DirectPath settings were evaluated before resolving credentials, so they would always take precedance

This PR changes the ordering to evaluate the credentials first, and disable DirectPath if not in the default universe

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request restricts DirectPath and DirectPath over Interconnect to the Google Default Universe (GDU), disabling them if either the target host or the resolved credential's universe domain is not 'googleapis.com'. To support this, credential resolution was refactored out of composite credential creation to allow checking the universe domain earlier. Comprehensive unit and integration tests have been added to verify this behavior for both synchronous and asynchronous channels. I have no feedback to provide as there are no review comments.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant