Repository navigation
feat(api_core): restrict DirectPath to default universe - #19163
Draft
daniel-sanche wants to merge 1 commit into
Draft
daniel-sanche wants to merge 1 commit into
daniel-sanche wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request restricts DirectPath and DirectPath over Interconnect to the Google Default Universe (GDU), disabling them if either the target host or the resolved credential's universe domain is not 'googleapis.com'. To support this, credential resolution was refactored out of composite credential creation to allow checking the universe domain earlier. Comprehensive unit and integration tests have been added to verify this behavior for both synchronous and asynchronous channels. I have no feedback to provide as there are no review comments.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DirectPath is only supported in the Google Default Universe (googleapis.com).
Previously, DirectPath settings were evaluated before resolving credentials, so they would always take precedance
This PR changes the ordering to evaluate the credentials first, and disable DirectPath if not in the default universe