Skip to content

ci: configure lint/docs tests using cloud build - #19123

Draft
parthea wants to merge 52 commits into
add-gcb-google-cloud-bigquery-storagefrom
migrate-lint-to-cloud-build
Draft

parthea wants to merge 52 commits into
add-gcb-google-cloud-bigquery-storagefrom
migrate-lint-to-cloud-build

Conversation

@parthea

@parthea parthea commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Towards b/578985802

@parthea parthea self-assigned this Nov 18, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new Cloud Build configuration file, ci/cloudbuild/lint-docs.yaml, designed to execute linting and documentation checks across parallel shards using nox and uv. Feedback on this PR highlights two key areas for improvement: first, replacing the fragile which -a lookup for the nox executable with python3 -m nox and making the Python logging wrapper robust against encoding errors; second, replacing the fragile ls wildcard expansion with a bash array to safely handle local wheel paths.

Comment thread ci/cloudbuild/lint-docs.yaml Resolved
Comment thread ci/cloudbuild/lint-docs.yaml Resolved
@parthea
parthea force-pushed the migrate-lint-to-cloud-build branch from 56ea8a4 to 0d6f4bf Compare November 18, 2026 18:26
@parthea
parthea force-pushed the add-gcb-google-cloud-bigquery-storage branch from 444f0b6 to 06aa46e Compare November 19, 2026 17:02
@parthea
parthea force-pushed the migrate-lint-to-cloud-build branch from 0d6f4bf to cba1d77 Compare November 19, 2026 17:08
@parthea
parthea force-pushed the add-gcb-google-cloud-bigquery-storage branch from fc0c135 to dbcc4d7 Compare November 19, 2026 18:32
@parthea
parthea force-pushed the add-gcb-google-cloud-bigquery-storage branch from 395f809 to c1fe2f1 Compare November 20, 2026 19:17

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant