feat(google/cloud/biglake/hive/v1): onboard a new library - #18172
feat(google/cloud/biglake/hive/v1): onboard a new library#18172quirogas wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds the Google Cloud BigLake Hive v1 client library, including its GAPIC client code, transports, types, generated samples, unit tests, and documentation. It also updates the Release Please and Librarian configurations to support releases for this new package. A high-severity issue was identified in release-please-individual-config.json where the paths to the gapic_version.py files were incorrectly specified using slashes instead of underscores, which would prevent Release Please from correctly locating and bumping the version files.
| "google/cloud/biglake/hive/gapic_version.py", | ||
| "google/cloud/biglake/hive_v1/gapic_version.py", | ||
| "google/cloud/biglake/hive_v1beta/gapic_version.py", |
There was a problem hiding this comment.
The paths to the gapic_version.py files are incorrect. The Python package namespace uses underscores (google/cloud/biglake_hive_v1) rather than slashes (google/cloud/biglake/hive_v1). This will cause Release Please to fail to locate and bump the version files during releases.
| "google/cloud/biglake/hive/gapic_version.py", | |
| "google/cloud/biglake/hive_v1/gapic_version.py", | |
| "google/cloud/biglake/hive_v1beta/gapic_version.py", | |
| "google/cloud/biglake_hive/gapic_version.py", | |
| "google/cloud/biglake_hive_v1/gapic_version.py", | |
| "google/cloud/biglake_hive_v1beta/gapic_version.py", |
|
Do not merge until #18013 has been merged. |
PiperOrigin-RevId: 966248502
Fixes b/548102568