Skip to content

feat(google/cloud/biglake/hive/v1): onboard a new library - #18172

Draft
quirogas wants to merge 1 commit into
googleapis:mainfrom
quirogas:onboard-biglake-hive-py
Draft

feat(google/cloud/biglake/hive/v1): onboard a new library#18172
quirogas wants to merge 1 commit into
googleapis:mainfrom
quirogas:onboard-biglake-hive-py

Conversation

@quirogas

Copy link
Copy Markdown
Contributor

PiperOrigin-RevId: 966248502
Fixes b/548102568

@quirogas
quirogas requested review from a team as code owners August 19, 2026 21:02
@snippet-bot

snippet-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 40 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the Google Cloud BigLake Hive v1 client library, including its GAPIC client code, transports, types, generated samples, unit tests, and documentation. It also updates the Release Please and Librarian configurations to support releases for this new package. A high-severity issue was identified in release-please-individual-config.json where the paths to the gapic_version.py files were incorrectly specified using slashes instead of underscores, which would prevent Release Please from correctly locating and bumping the version files.

Comment on lines +8 to +10
"google/cloud/biglake/hive/gapic_version.py",
"google/cloud/biglake/hive_v1/gapic_version.py",
"google/cloud/biglake/hive_v1beta/gapic_version.py",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The paths to the gapic_version.py files are incorrect. The Python package namespace uses underscores (google/cloud/biglake_hive_v1) rather than slashes (google/cloud/biglake/hive_v1). This will cause Release Please to fail to locate and bump the version files during releases.

Suggested change
"google/cloud/biglake/hive/gapic_version.py",
"google/cloud/biglake/hive_v1/gapic_version.py",
"google/cloud/biglake/hive_v1beta/gapic_version.py",
"google/cloud/biglake_hive/gapic_version.py",
"google/cloud/biglake_hive_v1/gapic_version.py",
"google/cloud/biglake_hive_v1beta/gapic_version.py",

@quirogas
quirogas marked this pull request as draft August 19, 2026 21:14
@quirogas
quirogas marked this pull request as ready for review August 20, 2026 14:36
@quirogas
quirogas marked this pull request as draft August 21, 2026 19:33
@quirogas quirogas added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 21, 2026
@quirogas

Copy link
Copy Markdown
Contributor Author

Do not merge until #18013 has been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant