Skip to content

for testing purposes - #18170

Draft
parthea wants to merge 2 commits into
mainfrom
chore-update-librarian-2026-08-19
Draft

for testing purposes#18170
parthea wants to merge 2 commits into
mainfrom
chore-update-librarian-2026-08-19

Conversation

@parthea

@parthea parthea commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the minimum supported version of google-api-core to 2.28.0 across various post-processing configurations and constraints. It introduces a compatibility module _compat.py in google-ads-admanager to handle older versions of google-api-core gracefully, and refactors all REST transports to utilize a centralized transcode_request helper, significantly reducing boilerplate code in the generated transport classes. Additionally, manual Python and dependency version checks in __init__.py have been replaced with direct calls to api_core. There are no review comments to assess, so I have no further feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant