Skip to content

fix(google-auth): add bounds for urllib3 and packaging dependencies#17647

Merged
ohmayr merged 3 commits into
mainfrom
add-urllib3-bounds-and-cleanup-todos
Jul 7, 2026
Merged

fix(google-auth): add bounds for urllib3 and packaging dependencies#17647
ohmayr merged 3 commits into
mainfrom
add-urllib3-bounds-and-cleanup-todos

Conversation

@ohmayr

@ohmayr ohmayr commented Jul 7, 2026

Copy link
Copy Markdown
Contributor
  1. setup.py:
    • Added version bounds for urllib3 and packaging in urllib3_extra_require:
      urllib3_extra_require = [
          "urllib3 >= 1.26.15, < 3.0.0",
          "packaging >= 20.0",
      ]
    • Set requests >= 2.30.0, < 3.0.0 for Python 3.10+ compatibility.
    • Resolved and removed TODO comment for issue Removing py26 and pandas from default tox environments. #1739.
  2. testing/constraints-3.10.txt:
    • Added requests==2.30.0, urllib3==1.26.15, and packaging==20.0 to lower-bound CI test constraints.

Fixes #15155 🦕

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces version bounds for the urllib3 and packaging dependencies in setup.py, addressing a TODO item. Additionally, it pins urllib3 to 1.26.15 and packaging to 20.0 in the testing constraints file constraints-3.10.txt. There are no review comments, and I have no feedback to provide.

@ohmayr ohmayr force-pushed the add-urllib3-bounds-and-cleanup-todos branch from 26bf556 to 7023aea Compare July 7, 2026 17:10
@parthea parthea marked this pull request as ready for review July 7, 2026 17:34
@parthea parthea requested review from a team as code owners July 7, 2026 17:34
@ohmayr ohmayr merged commit e9c6265 into main Jul 7, 2026
30 checks passed
@ohmayr ohmayr deleted the add-urllib3-bounds-and-cleanup-todos branch July 7, 2026 17:47
@release-please release-please Bot mentioned this pull request Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add bounds to the dependencies in urllib3_extra_require in setup.py

2 participants