fix(google-auth): add bounds for urllib3 and packaging dependencies#17647
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces version bounds for the urllib3 and packaging dependencies in setup.py, addressing a TODO item. Additionally, it pins urllib3 to 1.26.15 and packaging to 20.0 in the testing constraints file constraints-3.10.txt. There are no review comments, and I have no feedback to provide.
26bf556 to
7023aea
Compare
parthea
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup.py:urllib3andpackaginginurllib3_extra_require:requests >= 2.30.0, < 3.0.0for Python 3.10+ compatibility.testing/constraints-3.10.txt:requests==2.30.0,urllib3==1.26.15, andpackaging==20.0to lower-bound CI test constraints.Fixes #15155 🦕