Skip to content

chore(spanner): centralize mypy config for spanner#17641

Draft
chalmerlowe wants to merge 6 commits into
mainfrom
feat/centralize-mypy-spanner
Draft

chore(spanner): centralize mypy config for spanner#17641
chalmerlowe wants to merge 6 commits into
mainfrom
feat/centralize-mypy-spanner

Conversation

@chalmerlowe

@chalmerlowe chalmerlowe commented Jul 7, 2026

Copy link
Copy Markdown
Contributor
  • Relies on a centralized mypy.ini file at the root of the repository to consolidate all shared and package-specific mypy exceptions.
  • Deletes the individual mypy.ini files from handwritten libraries, establishing the root configuration as the source of truth.
  • Refactored their noxfile.py files to define MYPY_CONFIG_FILE dynamically and standardized their session.run("mypy", ...) invocations.

Related to: PR #17409 and PR #17640

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request centralizes the mypy configuration by removing the package-specific configuration file in packages/google-cloud-spanner and updating its noxfile.py to reference the root mypy.ini. The root configuration is also updated with various package-specific overrides. However, the override to ignore missing imports for google.iam.* from the deleted configuration was not migrated to the root mypy.ini, which will cause mypy checks to fail for the spanner package.

Comment thread mypy.ini
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant