Skip to content

feat(bigframes): Support groupby.agg/transform with udf transpiler#17613

Draft
TrevorBergeron wants to merge 3 commits into
mainfrom
tbergeron_bytecode_groups
Draft

feat(bigframes): Support groupby.agg/transform with udf transpiler#17613
TrevorBergeron wants to merge 3 commits into
mainfrom
tbergeron_bytecode_groups

Conversation

@TrevorBergeron

Copy link
Copy Markdown
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces subscripting support (via GetItemOp and DynamicGetItemOp) across Ibis, Polars, and SQLGlot compilers for arrays, structs, and strings. It also enables transpilation of custom Python functions (UDFs) within GroupBy aggregations and transformations. The review feedback highlights several critical runtime issues, including missing imports (bigframes and window_specs) that will cause NameErrors, and unhandled string-like inputs in the Polars implementation of GetItemOp.

Comment thread packages/bigframes/bigframes/core/block_transforms.py
Comment thread packages/bigframes/bigframes/core/groupby/dataframe_group_by.py
Comment thread packages/bigframes/bigframes/core/groupby/series_group_by.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant