Skip to content

feat(spanner): drop Python 3.7-3.9 support and regenerate#17169

Merged
chalmerlowe merged 3 commits into
mainfrom
fix-spanner-FTL-1.32.0
May 19, 2026
Merged

feat(spanner): drop Python 3.7-3.9 support and regenerate#17169
chalmerlowe merged 3 commits into
mainfrom
fix-spanner-FTL-1.32.0

Conversation

@chalmerlowe
Copy link
Copy Markdown
Contributor

Updates post processing to account for dropping support for Python 3.7, 3.8, 3.9 and the impacts that has on using 3.10 for lower bounds testing.

Changes

  • updates the lower bound versions for several libraries to avoid conflicts and install issues in both setup.py and constraints-3.10.txt
  • updates post-processing scripts to ensure the above updates persist

@chalmerlowe chalmerlowe added this to the generate via 1.32.0 milestone May 18, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request drops support for Python 3.9 across the Spanner client library, updating CI configurations, dependency constraints, and package initialization logic. However, several issues were identified in the review: the documentation in README.rst files incorrectly suggests that Python 3.9 is still supported while 3.8 is the limit, and the setup.py file contains inconsistent dependency downgrades for google-api-core and proto-plus. Additionally, missing f-string prefixes in __init__.py files for both database and instance admin packages will prevent proper variable interpolation in warning messages. Feedback also suggests ensuring that setup.py metadata (classifiers and python_requires) and the package versioning reflect this breaking change.

Comment thread packages/google-cloud-spanner/README.rst Outdated
Comment thread packages/google-cloud-spanner/docs/README.rst Outdated
Comment thread packages/google-cloud-spanner/setup.py Outdated
@chalmerlowe chalmerlowe marked this pull request as ready for review May 19, 2026 15:39
@chalmerlowe chalmerlowe requested review from a team as code owners May 19, 2026 15:39
@chalmerlowe chalmerlowe merged commit 2408166 into main May 19, 2026
31 checks passed
@chalmerlowe chalmerlowe deleted the fix-spanner-FTL-1.32.0 branch May 19, 2026 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants