feat(firestore): new generic pipeline expressions#16550
Draft
daniel-sanche wants to merge 12 commits intomainfrom
Draft
feat(firestore): new generic pipeline expressions#16550daniel-sanche wants to merge 12 commits intomainfrom
daniel-sanche wants to merge 12 commits intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces several new pipeline expressions to the Firestore library, including offset, coalesce, switch_on, parent, and a logical Nor operator, supported by new system and unit tests. The reviewer suggested refactoring the coalesce and switch_on methods for better conciseness and identified typos in the switch_on docstring and a unit test variable name.
packages/google-cloud-firestore/google/cloud/firestore_v1/pipeline_expressions.py
Outdated
Show resolved
Hide resolved
packages/google-cloud-firestore/google/cloud/firestore_v1/pipeline_expressions.py
Outdated
Show resolved
Hide resolved
packages/google-cloud-firestore/google/cloud/firestore_v1/pipeline_expressions.py
Outdated
Show resolved
Hide resolved
packages/google-cloud-firestore/tests/unit/v1/test_pipeline_expressions.py
Outdated
Show resolved
Hide resolved
daniel-sanche
changed the title
daniel-sanche
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Expressions:
Note: parent and reference_slice will be added in a separate PR. More detailed changes will be needed to support arbitrary collection/database references; currently only document references are supported