Skip to content

chore(ndb): Add nox sessions for system tests #16530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vbraun wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −0
Open

chore(ndb): Add nox sessions for system tests #16530

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/google-cloud-ndb/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,11 +189,13 @@ def cover(session):
session.run("coverage", "erase")


@nox.session(python=ALL_INTERPRETERS)
def old_emulator_system(session):
Comment on lines +192 to 193
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Exposing a function named old_emulator_system as a nox session can be confusing for developers, as the old_ prefix suggests it might be deprecated. If this function is not intended for regular use, it would be better not to expose it as a top-level session to avoid confusion. Please consider removing the @nox.session decorator.

Suggested change
@nox.session(python=ALL_INTERPRETERS)
def old_emulator_system(session):
def old_emulator_system(session):

emulator_args = ["gcloud", "beta", "emulators", "datastore", "start"]
_run_emulator(session, emulator_args)


@nox.session(python=ALL_INTERPRETERS)
def emulator_system(session):
emulator_args = [
"gcloud",
Expand Down
Loading