Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the Kokoro presubmit configuration for Linux by changing the build script from bypass.sh to build.sh. The review feedback suggests restoring the explanatory comments and vertical spacing that were removed during the update to maintain readability and configuration clarity, along with adding a trailing newline to the file.
| action { | ||
| define_artifacts { | ||
| regex: "**/*sponge_log.xml" | ||
| } | ||
| } | ||
|
|
||
| # Bypass the trampoline entirely and run our dummy script natively | ||
| build_file: "google-cloud-python/packages/google-crc32c/scripts/bypass.sh" No newline at end of file | ||
| build_file: "google-cloud-python/packages/google-crc32c/scripts/build.sh" No newline at end of file |
There was a problem hiding this comment.
The removal of explanatory comments and vertical spacing reduces the maintainability of the configuration. It is recommended to retain comments that explain the purpose of specific settings (like the artifact regex workaround for Kokoro 404s) and to use blank lines to separate top-level configuration blocks for better readability. Additionally, adding a newline at the end of the file is a standard practice.
| action { | |
| define_artifacts { | |
| regex: "**/*sponge_log.xml" | |
| } | |
| } | |
| # Bypass the trampoline entirely and run our dummy script natively | |
| build_file: "google-cloud-python/packages/google-crc32c/scripts/bypass.sh" | |
| \ No newline at end of file | |
| build_file: "google-cloud-python/packages/google-crc32c/scripts/build.sh" | |
| # Tell Kokoro where to find the test logs so it doesn't 404 | |
| action { | |
| define_artifacts { | |
| regex: "**/*sponge_log.xml" | |
| } | |
| } | |
| # Run the build script natively | |
| build_file: "google-cloud-python/packages/google-crc32c/scripts/build.sh" | |
e700706 to
d3954f6
Compare
d3954f6 to
6da21f2
Compare
6da21f2 to
69c703c
Compare
69c703c to
c9af94b
Compare
enable python-crc32c kokoro presubmits
Fixes: #16512