Skip to content

chore: enable python-crc32c kokoro presubmits#16524

Draft
ohmayr wants to merge 1 commit intomainfrom
fix-kokoro-presubmits-for-crc32c
Draft

chore: enable python-crc32c kokoro presubmits#16524
ohmayr wants to merge 1 commit intomainfrom
fix-kokoro-presubmits-for-crc32c

Conversation

@ohmayr
Copy link
Copy Markdown
Contributor

@ohmayr ohmayr commented Apr 1, 2026

enable python-crc32c kokoro presubmits

Fixes: #16512

@ohmayr ohmayr requested review from a team as code owners April 1, 2026 22:23
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Kokoro presubmit configuration for Linux by changing the build script from bypass.sh to build.sh. The review feedback suggests restoring the explanatory comments and vertical spacing that were removed during the update to maintain readability and configuration clarity, along with adding a trailing newline to the file.

Comment on lines +2 to +7
action {
define_artifacts {
regex: "**/*sponge_log.xml"
}
}

# Bypass the trampoline entirely and run our dummy script natively
build_file: "google-cloud-python/packages/google-crc32c/scripts/bypass.sh" No newline at end of file
build_file: "google-cloud-python/packages/google-crc32c/scripts/build.sh" No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The removal of explanatory comments and vertical spacing reduces the maintainability of the configuration. It is recommended to retain comments that explain the purpose of specific settings (like the artifact regex workaround for Kokoro 404s) and to use blank lines to separate top-level configuration blocks for better readability. Additionally, adding a newline at the end of the file is a standard practice.

Suggested change
action {
define_artifacts {
regex: "**/*sponge_log.xml"
}
}
# Bypass the trampoline entirely and run our dummy script natively
build_file: "google-cloud-python/packages/google-crc32c/scripts/bypass.sh"
\ No newline at end of file
build_file: "google-cloud-python/packages/google-crc32c/scripts/build.sh"
# Tell Kokoro where to find the test logs so it doesn't 404
action {
define_artifacts {
regex: "**/*sponge_log.xml"
}
}
# Run the build script natively
build_file: "google-cloud-python/packages/google-crc32c/scripts/build.sh"

@ohmayr ohmayr force-pushed the fix-kokoro-presubmits-for-crc32c branch 2 times, most recently from e700706 to d3954f6 Compare April 1, 2026 23:00
Copy link
Copy Markdown

@avijitsahaaornoy avijitsahaaornoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bypasse

Copy link
Copy Markdown

@avijitsahaaornoy avijitsahaaornoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi

@ohmayr ohmayr force-pushed the fix-kokoro-presubmits-for-crc32c branch from d3954f6 to 6da21f2 Compare April 1, 2026 23:09
@ohmayr ohmayr marked this pull request as draft April 1, 2026 23:33
@ohmayr ohmayr force-pushed the fix-kokoro-presubmits-for-crc32c branch from 6da21f2 to 69c703c Compare April 2, 2026 07:05
@ohmayr ohmayr force-pushed the fix-kokoro-presubmits-for-crc32c branch from 69c703c to c9af94b Compare April 2, 2026 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

google-crc32c: Wire up cross-platform Kokoro builds, including release scripts

2 participants