chore(firestore): skip pipeline verification tests outside enterprise db#16523
Open
daniel-sanche wants to merge 4 commits intomainfrom
Open
chore(firestore): skip pipeline verification tests outside enterprise db#16523daniel-sanche wants to merge 4 commits intomainfrom
daniel-sanche wants to merge 4 commits intomainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the verify_pipeline function in both synchronous and asynchronous system tests to include checks for the Firestore emulator and enterprise database requirements. The reviewer recommends using pytest.skip() instead of print() and return to ensure that tests are accurately reported as skipped in the test results, rather than appearing as passed when the conditions are not met.
packages/google-cloud-firestore/tests/system/test_system_async.py
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firestore system tests are currently failing, because they attempt to run pipeline verification tests on all test dbs. Pipelines mode is only supported on enterprise databases, so we should skip the test on unsupported environments
While making this change, I ended up also reporting this as a pytest subtest, to make the test results/skips more clear